[Bug tdep/29247] [gdb, tdep] ../../gdb/ppc-sysv-tdep.c:1945: internal-error: ppc64_sysv_abi_return_value: Assertion `ok' failed

["vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=29247

--- Comment #7 from Tom de Vries <vries at gcc dot gnu.org> ---
I finally remembered that I can use osc to build the gdb package for the
tumbleweed distro, even if the powerpc machine isn't running tumbleweed.

So, I managed to reproduce with the possibility to debug and try out fixes.

As a first try, I added this code:
...
  if (tdep->elf_abi == POWERPC_ELF_V2
      && TYPE_LENGTH (valtype) == 16
      && valtype->code () == TYPE_CODE_FLT
      && (gdbarch_long_double_format (gdbarch)
          == floatformats_ia64_quad))
    {
      int regnum = tdep->ppc_vsr0_regnum + 32 + 2 + index;

      if (writebuf != NULL)
        {
          regcache->cooked_write (regnum, writebuf);
        }
      if (readbuf != NULL)
        {
          regcache->cooked_read (regnum, readbuf);
        }
      return 1;
    }
...
and that fixes the problem at hand, iow:
...
$ gdb -q -batch -ex start -ex "p t_structs_ldc(struct_val1)" \ 
    ./gdb/testsuite.unix.-m64/outputs/gdb.base/callfuncs/callfuncs
Temporary breakpoint 1 at 0x4ce4: file gdb/testsuite/gdb.base/callfuncs.c, line
647.
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".

Temporary breakpoint 1, main () at
/home/abuild/rpmbuild/BUILD/gdb-11.1/gdb/testsuite/gdb.base/callfuncs.c:647
647       void *p = malloc (1);
$1 = 5 + 5i
...

I'm not sure if the tdep->elf_abi == POWERPC_ELF_V2 and
gdbarch_long_double_format (gdbarch) == floatformats_ia64_quad are both
necessary.

Still, four fails lefts:
...
FAIL: gdb.base/callfuncs.exp: p t_long_double_complex_values(ldc1, ldc2)
FAIL: gdb.base/callfuncs.exp: p t_long_double_complex_many_args(ldc1, ldc2,
ldc3, ldc4, ldc1, ldc2, ldc3, ldc4, ldc1, ldc2, ldc3, ldc4, ldc1, ldc2, ldc3,
ldc4)
FAIL: gdb.base/callfuncs.exp: noproto: p t_long_double_complex_values(ldc1,
ldc2)
FAIL: gdb.base/callfuncs.exp: noproto: p t_long_double_complex_many_args(ldc1,
ldc2, ldc3, ldc4, ldc1, ldc2, ldc3, ldc4, ldc1, ldc2, ldc3, ldc4, ldc1, ldc2,
ldc3, ldc4)
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.