From: Siddhesh Poyarekar <siddhesh@sourceware.org>
To: Szabolcs Nagy <szabolcs.nagy@arm.com>, libc-alpha@sourceware.org
Cc: adhemerval.zanella@linaro.org, fweimer@redhat.com, carlos@redhat.com
Subject: Re: [PATCH 2/2] aarch64: Make glibc.mem.tagging SXID_ERASE
Date: Wed, 4 Oct 2023 11:05:43 -0400 [thread overview]
Message-ID: <c736780c-71b5-4718-cbb3-dac202b3b4d3@sourceware.org> (raw)
In-Reply-To: <240d1f1a-685a-2281-531f-00fd4f2cf1a6@sourceware.org>
On 2023-10-04 10:53, Siddhesh Poyarekar wrote:
> On 2023-10-04 10:51, Szabolcs Nagy wrote:
>> personally i think setuid binaries should not touch the
>> env, just ignore it, so everything SXID_IGNORE.
>>
>> it's not just the string twiddling but tunables_strdup
>> is a problem too (it can fail, needs early alloc,..).
>> ideally tunables_init would be a nop with AT_SECURE and
>> otherwise parsed the env var without malloc and touching
>> the env[] array passed by the kernel.
>>
>
> Sure, that could be a less contentious change. I'll send v2 with it.
I should clarify though, that I'm not removing tunables_strdup because
it's still needed for regular tunables processing. The v2 I'm testing
will simply make all tunables SXID_IGNORE and tunables_init a nop with
AT_SECURE.
Sid
next prev parent reply other threads:[~2023-10-04 15:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 20:11 [PATCH 0/2] make all tunables SXID_ERASE Siddhesh Poyarekar
2023-10-03 20:11 ` [PATCH 1/2] Make all malloc " Siddhesh Poyarekar
2023-10-03 20:11 ` [PATCH 2/2] aarch64: Make glibc.mem.tagging SXID_ERASE Siddhesh Poyarekar
2023-10-04 7:29 ` Szabolcs Nagy
2023-10-04 11:59 ` Siddhesh Poyarekar
2023-10-04 14:04 ` Szabolcs Nagy
2023-10-04 14:23 ` Siddhesh Poyarekar
2023-10-04 14:51 ` Szabolcs Nagy
2023-10-04 14:53 ` Siddhesh Poyarekar
2023-10-04 15:05 ` Siddhesh Poyarekar [this message]
2023-10-04 17:01 ` Adhemerval Zanella Netto
2023-10-05 8:19 ` Szabolcs Nagy
2023-10-05 12:55 ` Siddhesh Poyarekar
2023-10-05 13:59 ` Szabolcs Nagy
2023-10-05 14:05 ` Siddhesh Poyarekar
2023-10-05 18:31 ` Zack Weinberg
2023-10-05 19:11 ` Siddhesh Poyarekar
2023-10-06 12:25 ` Zack Weinberg
2023-10-06 12:41 ` Siddhesh Poyarekar
2023-10-06 17:10 ` Adhemerval Zanella Netto
2023-10-06 18:04 ` Siddhesh Poyarekar
2023-10-08 19:51 ` Michael Hudson-Doyle
2023-10-31 19:58 ` Zack Weinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c736780c-71b5-4718-cbb3-dac202b3b4d3@sourceware.org \
--to=siddhesh@sourceware.org \
--cc=adhemerval.zanella@linaro.org \
--cc=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=szabolcs.nagy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).