public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: agk@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW tools/lvcreate.c Date: Thu, 26 Oct 2006 18:22:00 -0000 [thread overview] Message-ID: <20061026182211.15667.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: agk@sourceware.org 2006-10-26 18:22:10 Modified files: . : WHATS_NEW tools : lvcreate.c Log message: When adding snapshot leave cow LV mapped device active after zeroing. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.482&r2=1.483 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvcreate.c.diff?cvsroot=lvm2&r1=1.128&r2=1.129 --- LVM2/WHATS_NEW 2006/10/24 19:07:32 1.482 +++ LVM2/WHATS_NEW 2006/10/26 18:22:10 1.483 @@ -1,5 +1,6 @@ Version 2.02.13 - =================================== + When adding snapshot leave cow LV mapped device active after zeroing. Fix a clvmd debug message. Add dev_flush() to set_lv(). Add lvchange --resync. --- LVM2/tools/lvcreate.c 2006/10/18 18:01:53 1.128 +++ LVM2/tools/lvcreate.c 2006/10/26 18:22:10 1.129 @@ -761,13 +761,14 @@ return 0; } - if (!activate_lv(cmd, lv)) { - if (lp->snapshot) - /* FIXME Remove the failed lv we just added */ + if (lp->snapshot) { + if (!activate_lv_excl(cmd, lv)) { log_error("Aborting. Failed to activate snapshot " "exception store. Remove new LV and retry."); - else - log_error("Failed to activate new LV."); + return 0; + } + } else if (!activate_lv(cmd, lv)) { + log_error("Failed to activate new LV."); return 0; } @@ -787,10 +788,8 @@ /* Reset permission after zeroing */ if (!(lp->permission & LVM_WRITE)) lv->status &= ~LVM_WRITE; - if (!deactivate_lv(cmd, lv)) { - log_err("Couldn't deactivate new snapshot."); - return 0; - } + + /* cow LV remains active and becomes snapshot LV */ if (!vg_add_snapshot(vg->fid, NULL, org, lv, NULL, org->le_count, lp->chunk_size)) {
next reply other threads:[~2006-10-26 18:22 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2006-10-26 18:22 agk [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-04-11 12:33 zkabelac 2012-03-02 17:25 zkabelac 2012-03-01 21:21 zkabelac 2012-02-27 10:00 zkabelac 2011-11-07 11:01 zkabelac 2011-09-22 15:36 jbrassow 2008-09-24 16:32 mbroz 2008-06-05 13:38 agk 2008-01-17 15:53 agk 2008-01-16 15:25 agk 2007-11-12 13:34 agk 2007-09-24 13:25 wysochanski 2007-09-17 17:18 agk 2007-07-17 16:13 mbroz 2006-05-24 13:58 agk 2005-06-22 14:56 agk 2004-10-15 15:53 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20061026182211.15667.qmail@sourceware.org \ --to=agk@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).