public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW tools/lvcreate.c Date: Wed, 11 Apr 2012 12:33:00 -0000 [thread overview] Message-ID: <20120411123337.7848.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2012-04-11 12:33:35 Modified files: . : WHATS_NEW tools : lvcreate.c Log message: Support rounding downward for lvcreate and % If specifying size with % and we are reaching number of free extents - round downward with stripes. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2378&r2=1.2379 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvcreate.c.diff?cvsroot=lvm2&r1=1.263&r2=1.264 --- LVM2/WHATS_NEW 2012/04/11 09:12:02 1.2378 +++ LVM2/WHATS_NEW 2012/04/11 12:33:34 1.2379 @@ -1,5 +1,6 @@ Version 2.02.96 - ================================ + For lvcreate with %FREE support rounding downward strip alignment. Change message severity to log_very_verbose for missing dev info in udev db. Fix problems when specifying PVs during RAID down-converts. Fix ability to handle failures in mirrored log (regression intro 2.02.89). --- LVM2/tools/lvcreate.c 2012/03/06 09:22:03 1.263 +++ LVM2/tools/lvcreate.c 2012/04/11 12:33:35 1.264 @@ -236,6 +236,8 @@ uint32_t pv_extent_count; struct logical_volume *origin = NULL; int changed = 0; + uint32_t size_rest; + uint32_t stripesize_extents; if (lcp->size && !(lp->extents = extents_from_size(vg->cmd, lcp->size, @@ -294,6 +296,18 @@ break; } + if (!(stripesize_extents = lp->stripe_size / vg->extent_size)) + stripesize_extents = 1; + + if ((lcp->percent != PERCENT_NONE) && lp->stripes && + (size_rest = lp->extents % (lp->stripes * stripesize_extents)) && + (vg->free_count < lp->extents - size_rest + (lp->stripes * stripesize_extents))) { + log_print("Rounding size (%d extents) down to stripe boundary " + "size (%d extents)", lp->extents, + lp->extents - size_rest); + lp->extents = lp->extents - size_rest; + } + if (lp->create_thin_pool) { if (!arg_count(vg->cmd, poolmetadatasize_ARG)) { /* Defaults to nr_pool_blocks * 64b */
next reply other threads:[~2012-04-11 12:33 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-04-11 12:33 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-03-02 17:25 zkabelac 2012-03-01 21:21 zkabelac 2012-02-27 10:00 zkabelac 2011-11-07 11:01 zkabelac 2011-09-22 15:36 jbrassow 2008-09-24 16:32 mbroz 2008-06-05 13:38 agk 2008-01-17 15:53 agk 2008-01-16 15:25 agk 2007-11-12 13:34 agk 2007-09-24 13:25 wysochanski 2007-09-17 17:18 agk 2007-07-17 16:13 mbroz 2006-10-26 18:22 agk 2006-05-24 13:58 agk 2005-06-22 14:56 agk 2004-10-15 15:53 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120411123337.7848.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).