From: "H.J. Lu" <hjl.tools@gmail.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "Jiang, Haochen" <haochen.jiang@intel.com>,
Binutils <binutils@sourceware.org>
Subject: Re: [PATCH 3/5] x86: support AVX10.1/512
Date: Tue, 29 Aug 2023 09:18:44 -0700 [thread overview]
Message-ID: <CAMe9rOr99kw4MbJ1snBzLAWNnuwdW-QS9Rf2jZWZErGZXMkh4A@mail.gmail.com> (raw)
In-Reply-To: <3dc8a453-eb31-1caa-c003-4bee60bf0863@suse.com>
On Mon, Aug 28, 2023 at 12:09 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 28.08.2023 08:59, Jiang, Haochen wrote:
> >> But of course the question remains on whether this is needed in the first
> >> place. Personally I'd favor making AES a prereq of VAES (and PCLMULQDQ one
> >> of VPCLMULQDQ); if we decided to go that route, I'd make that change a
> >
> > For PCLMULQDQ and VPCLMULQDQ, the imply should be ok. Actually, I have
> > added that in GCC in April, but I forgot to check Binutils at that time:
> >
> > https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=4246611d1915f1664c01f286dbeb946dd06e2a4d
> >
> > For AES/VAES, I am conservative on that at that time because not all the insts are
> > included in VAES:
> >
> > https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=24a8acc1662c37003a7b54814bf840019fec2190
> >
> > But I suppose the reason why AESIMC/AESKEYGENASSIST are not included might
> > be one key length is 128 bit while generating/transforming two at the same time
> > and putting them into ymm register is not quite needed.
>
> Plus VAES is going to be of less use without those two insns, so assuming
> AES to also be there if VAES is ought to be sufficiently "natural". Yet
> as said, it would be quite nice if the SDM could make such "connections"
> explicit.
>
> > I am both ok on whether to imply or not since it would be simple if implied.
>
> Okay, I'll tentatively add a new prereq patch then, but before posting v2
> I'd like to give H.J. the opportunity to voice an opinion.
>
I don't think we need to make AVX10 to imply AES and VPCLMULQDQ
in assembler. The AES and PCLMULQDQ changes aren't needed.
--
H.J.
next prev parent reply other threads:[~2023-08-29 16:19 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 12:43 [PATCH 0/5] x86: AVX10.1 (alternative attempt) Jan Beulich
2023-08-25 12:44 ` [PATCH 1/5] x86: correct source used for two non-AVX512 VEXWIG tests Jan Beulich
2023-08-25 12:45 ` [PATCH 2/5] x86: rename CpuPCLMUL Jan Beulich
2023-08-25 12:46 ` [PATCH 3/5] x86: support AVX10.1/512 Jan Beulich
2023-08-28 2:34 ` Jiang, Haochen
2023-08-28 6:45 ` Jan Beulich
2023-08-28 6:59 ` Jiang, Haochen
2023-08-28 7:09 ` Jan Beulich
2023-08-29 16:18 ` H.J. Lu [this message]
2023-08-30 1:10 ` Jiang, Haochen
2023-08-30 7:47 ` Jan Beulich
2023-08-30 15:28 ` H.J. Lu
2023-09-01 8:41 ` Jan Beulich
2023-09-01 8:52 ` Jiang, Haochen
2023-09-01 9:57 ` Jan Beulich
2023-09-05 7:04 ` Jiang, Haochen
2023-09-05 7:25 ` Jan Beulich
2023-08-25 12:47 ` [PATCH 4/5] x86: unindent most of set_cpu_arch() Jan Beulich
2023-08-25 12:47 ` [PATCH 5/5] x86: support AVX10.1 vector size restrictions Jan Beulich
2023-08-29 16:26 ` H.J. Lu
2023-08-30 7:57 ` Jan Beulich
2023-08-30 15:25 ` H.J. Lu
2023-08-30 16:16 ` Jan Beulich
2023-08-30 18:00 ` H.J. Lu
2023-08-31 5:56 ` Jiang, Haochen
2023-08-31 7:18 ` Jan Beulich
2023-09-01 6:21 ` Jiang, Haochen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOr99kw4MbJ1snBzLAWNnuwdW-QS9Rf2jZWZErGZXMkh4A@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=binutils@sourceware.org \
--cc=haochen.jiang@intel.com \
--cc=jbeulich@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).