[PATCH] libgccjit: Fix a failing test

[PATCH] libgccjit: Fix a failing test

[Guillaume Gomez]

[-- Attachment #1.1: Type: text/plain, Size: 63 bytes --]

Hi,

This fixes bug 107999.

Thanks in advance for the review.

[-- Attachment #2: 0001-Fix-a-failing-test-by-updating-its-error-string.patch --]
[-- Type: text/x-patch, Size: 1018 bytes --]

From e6db0cb107e54789095f4585dd279a2c984d2ca1 Mon Sep 17 00:00:00 2001
From: Guillaume Gomez <guillaume1.gomez@gmail.com>
Date: Wed, 14 Dec 2022 14:28:22 +0100
Subject: [PATCH] Fix a failing test by updating its error string.

gcc/testsuite/ChangeLog:

	* jit.dg/test-error-array-bounds.c: Update test.
---
 gcc/testsuite/jit.dg/test-error-array-bounds.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/testsuite/jit.dg/test-error-array-bounds.c b/gcc/testsuite/jit.dg/test-error-array-bounds.c
index b6c0ee526d4..a0dead13cb7 100644
--- a/gcc/testsuite/jit.dg/test-error-array-bounds.c
+++ b/gcc/testsuite/jit.dg/test-error-array-bounds.c
@@ -70,5 +70,5 @@ verify_code (gcc_jit_context *ctxt, gcc_jit_result *result)
   /* ...and that the message was captured by the API.  */
   CHECK_STRING_VALUE (gcc_jit_context_get_first_error (ctxt),
 		      "array subscript 10 is above array bounds of"
-		      " 'char[10]' [-Warray-bounds]");
+		      " 'char[10]' [-Warray-bounds=]");
 }
-- 
2.34.1

Re: [PATCH] libgccjit: Fix a failing test

[Antoni Boucher]

Thanks!

In your patch, you're missing this line at the end of the commit
message:

   Signed-off-by: Guillaume Gomez <guillaume1.gomez@gmail.com>

On Wed, 2022-12-14 at 14:39 +0100, Guillaume Gomez via Jit wrote:
> Hi,
> 
> This fixes bug 107999.
> 
> Thanks in advance for the review.

Re: [PATCH] libgccjit: Fix a failing test

[Guillaume Gomez]

[-- Attachment #1.1: Type: text/plain, Size: 526 bytes --]

Forgot it indeed, thanks for notifying me!

I modified the commit message to add it and added it into this email.

Le mer. 14 déc. 2022 à 16:12, Antoni Boucher <bouanto@zoho.com> a écrit :

> Thanks!
>
> In your patch, you're missing this line at the end of the commit
> message:
>
>    Signed-off-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
>
> On Wed, 2022-12-14 at 14:39 +0100, Guillaume Gomez via Jit wrote:
> > Hi,
> >
> > This fixes bug 107999.
> >
> > Thanks in advance for the review.
>
>

[-- Attachment #2: 0001-Fix-a-failing-test-by-updating-its-error-string.patch --]
[-- Type: text/x-patch, Size: 1079 bytes --]

From 30f049d4f39de392dbb3cff4b64779f2507fc914 Mon Sep 17 00:00:00 2001
From: Guillaume Gomez <guillaume1.gomez@gmail.com>
Date: Wed, 14 Dec 2022 14:28:22 +0100
Subject: [PATCH] Fix a failing test by updating its error string.

gcc/testsuite/ChangeLog:

	* jit.dg/test-error-array-bounds.c: Update test.

Signed-off-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
---
 gcc/testsuite/jit.dg/test-error-array-bounds.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/testsuite/jit.dg/test-error-array-bounds.c b/gcc/testsuite/jit.dg/test-error-array-bounds.c
index b6c0ee526d4..a0dead13cb7 100644
--- a/gcc/testsuite/jit.dg/test-error-array-bounds.c
+++ b/gcc/testsuite/jit.dg/test-error-array-bounds.c
@@ -70,5 +70,5 @@ verify_code (gcc_jit_context *ctxt, gcc_jit_result *result)
   /* ...and that the message was captured by the API.  */
   CHECK_STRING_VALUE (gcc_jit_context_get_first_error (ctxt),
 		      "array subscript 10 is above array bounds of"
-		      " 'char[10]' [-Warray-bounds]");
+		      " 'char[10]' [-Warray-bounds=]");
 }
-- 
2.34.1

Re: [PATCH] libgccjit: Fix a failing test

[Guillaume Gomez]

[-- Attachment #1: Type: text/plain, Size: 656 bytes --]

Ping David

Le jeu. 15 déc. 2022 à 11:34, Guillaume Gomez <guillaume1.gomez@gmail.com>
a écrit :

> Forgot it indeed, thanks for notifying me!
>
> I modified the commit message to add it and added it into this email.
>
> Le mer. 14 déc. 2022 à 16:12, Antoni Boucher <bouanto@zoho.com> a écrit :
>
>> Thanks!
>>
>> In your patch, you're missing this line at the end of the commit
>> message:
>>
>>    Signed-off-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
>>
>> On Wed, 2022-12-14 at 14:39 +0100, Guillaume Gomez via Jit wrote:
>> > Hi,
>> >
>> > This fixes bug 107999.
>> >
>> > Thanks in advance for the review.
>>
>>

Re: [PATCH] libgccjit: Fix a failing test

[Guillaume Gomez]

[-- Attachment #1: Type: text/plain, Size: 792 bytes --]

Ping David.

Le sam. 24 déc. 2022 à 21:01, Guillaume Gomez <guillaume1.gomez@gmail.com>
a écrit :

> Ping David
>
> Le jeu. 15 déc. 2022 à 11:34, Guillaume Gomez <guillaume1.gomez@gmail.com>
> a écrit :
>
>> Forgot it indeed, thanks for notifying me!
>>
>> I modified the commit message to add it and added it into this email.
>>
>> Le mer. 14 déc. 2022 à 16:12, Antoni Boucher <bouanto@zoho.com> a écrit :
>>
>>> Thanks!
>>>
>>> In your patch, you're missing this line at the end of the commit
>>> message:
>>>
>>>    Signed-off-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
>>>
>>> On Wed, 2022-12-14 at 14:39 +0100, Guillaume Gomez via Jit wrote:
>>> > Hi,
>>> >
>>> > This fixes bug 107999.
>>> >
>>> > Thanks in advance for the review.
>>>
>>>

Re: [PATCH] libgccjit: Fix a failing test

[Guillaume Gomez]

[-- Attachment #1: Type: text/plain, Size: 937 bytes --]

Ping David.

Le jeu. 5 janv. 2023 à 23:37, Guillaume Gomez <guillaume1.gomez@gmail.com>
a écrit :

> Ping David.
>
> Le sam. 24 déc. 2022 à 21:01, Guillaume Gomez <guillaume1.gomez@gmail.com>
> a écrit :
>
>> Ping David
>>
>> Le jeu. 15 déc. 2022 à 11:34, Guillaume Gomez <guillaume1.gomez@gmail.com>
>> a écrit :
>>
>>> Forgot it indeed, thanks for notifying me!
>>>
>>> I modified the commit message to add it and added it into this email.
>>>
>>> Le mer. 14 déc. 2022 à 16:12, Antoni Boucher <bouanto@zoho.com> a
>>> écrit :
>>>
>>>> Thanks!
>>>>
>>>> In your patch, you're missing this line at the end of the commit
>>>> message:
>>>>
>>>>    Signed-off-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
>>>>
>>>> On Wed, 2022-12-14 at 14:39 +0100, Guillaume Gomez via Jit wrote:
>>>> > Hi,
>>>> >
>>>> > This fixes bug 107999.
>>>> >
>>>> > Thanks in advance for the review.
>>>>
>>>>

Re: [PATCH] libgccjit: Fix a failing test

[Guillaume Gomez]

[-- Attachment #1: Type: text/plain, Size: 1085 bytes --]

Ping David.

Le lun. 16 janv. 2023 à 15:08, Guillaume Gomez <guillaume1.gomez@gmail.com>
a écrit :

> Ping David.
>
> Le jeu. 5 janv. 2023 à 23:37, Guillaume Gomez <guillaume1.gomez@gmail.com>
> a écrit :
>
>> Ping David.
>>
>> Le sam. 24 déc. 2022 à 21:01, Guillaume Gomez <guillaume1.gomez@gmail.com>
>> a écrit :
>>
>>> Ping David
>>>
>>> Le jeu. 15 déc. 2022 à 11:34, Guillaume Gomez <
>>> guillaume1.gomez@gmail.com> a écrit :
>>>
>>>> Forgot it indeed, thanks for notifying me!
>>>>
>>>> I modified the commit message to add it and added it into this email.
>>>>
>>>> Le mer. 14 déc. 2022 à 16:12, Antoni Boucher <bouanto@zoho.com> a
>>>> écrit :
>>>>
>>>>> Thanks!
>>>>>
>>>>> In your patch, you're missing this line at the end of the commit
>>>>> message:
>>>>>
>>>>>    Signed-off-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
>>>>>
>>>>> On Wed, 2022-12-14 at 14:39 +0100, Guillaume Gomez via Jit wrote:
>>>>> > Hi,
>>>>> >
>>>>> > This fixes bug 107999.
>>>>> >
>>>>> > Thanks in advance for the review.
>>>>>
>>>>>

Re: [PATCH] libgccjit: Fix a failing test

[David Malcolm]

On Thu, 2022-12-15 at 08:34 +0100, Guillaume Gomez via Jit wrote:
> Forgot it indeed, thanks for notifying me!
> 
> I modified the commit message to add it and added it into this email.

Sorry about the delay in reviewing this; for some reason I didn't see
the mail.

The patch looks good for trunk, but please add a reference to
  PR jit/107999
to the subject line and ChangeLog message.

Dave

> 
> Le mer. 14 déc. 2022 à 16:12, Antoni Boucher <bouanto@zoho.com> a
> écrit :
> 
> > Thanks!
> > 
> > In your patch, you're missing this line at the end of the commit
> > message:
> > 
> >    Signed-off-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
> > 
> > On Wed, 2022-12-14 at 14:39 +0100, Guillaume Gomez via Jit wrote:
> > > Hi,
> > > 
> > > This fixes bug 107999.
> > > 
> > > Thanks in advance for the review.
> > 
> > 

Re: [PATCH] libgccjit: Fix a failing test

[Guillaume Gomez]

[-- Attachment #1.1: Type: text/plain, Size: 1100 bytes --]

No problem, thanks for the explanations.

I joined the patch with the fixed commit message.

Le jeu. 2 mars 2023 à 22:58, David Malcolm <dmalcolm@redhat.com> a écrit :

> On Thu, 2022-12-15 at 08:34 +0100, Guillaume Gomez via Jit wrote:
> > Forgot it indeed, thanks for notifying me!
> >
> > I modified the commit message to add it and added it into this email.
>
> Sorry about the delay in reviewing this; for some reason I didn't see
> the mail.
>
> The patch looks good for trunk, but please add a reference to
>   PR jit/107999
> to the subject line and ChangeLog message.
>
> Dave
>
> >
> > Le mer. 14 déc. 2022 à 16:12, Antoni Boucher <bouanto@zoho.com> a
> > écrit :
> >
> > > Thanks!
> > >
> > > In your patch, you're missing this line at the end of the commit
> > > message:
> > >
> > >    Signed-off-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
> > >
> > > On Wed, 2022-12-14 at 14:39 +0100, Guillaume Gomez via Jit wrote:
> > > > Hi,
> > > >
> > > > This fixes bug 107999.
> > > >
> > > > Thanks in advance for the review.
> > >
> > >
>
>

[-- Attachment #2: 0001-Fix-a-failing-test-by-updating-its-error-string.patch --]
[-- Type: text/x-patch, Size: 1119 bytes --]

From 985228a76feecf16658b95a012e0b531e7e5c750 Mon Sep 17 00:00:00 2001
From: Guillaume Gomez <guillaume1.gomez@gmail.com>
Date: Wed, 14 Dec 2022 14:28:22 +0100
Subject: [PATCH] [PATCH] Fix a failing test by updating its error string
 [PR107999]

gcc/testsuite/ChangeLog:
        PR jit/107999
	* jit.dg/test-error-array-bounds.c: Update test.

Signed-off-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
---
 gcc/testsuite/jit.dg/test-error-array-bounds.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/testsuite/jit.dg/test-error-array-bounds.c b/gcc/testsuite/jit.dg/test-error-array-bounds.c
index b6c0ee526d4..a0dead13cb7 100644
--- a/gcc/testsuite/jit.dg/test-error-array-bounds.c
+++ b/gcc/testsuite/jit.dg/test-error-array-bounds.c
@@ -70,5 +70,5 @@ verify_code (gcc_jit_context *ctxt, gcc_jit_result *result)
   /* ...and that the message was captured by the API.  */
   CHECK_STRING_VALUE (gcc_jit_context_get_first_error (ctxt),
 		      "array subscript 10 is above array bounds of"
-		      " 'char[10]' [-Warray-bounds]");
+		      " 'char[10]' [-Warray-bounds=]");
 }
-- 
2.34.1

Re: [PATCH] libgccjit: Fix a failing test

[Guillaume Gomez]

[-- Attachment #1.1: Type: text/plain, Size: 1331 bytes --]

Just realized I used whitespace and not a tab. Sorry about that. Here's the
fixed version...

Le jeu. 2 mars 2023 à 23:19, Guillaume Gomez <guillaume1.gomez@gmail.com> a
écrit :

> No problem, thanks for the explanations.
>
> I joined the patch with the fixed commit message.
>
> Le jeu. 2 mars 2023 à 22:58, David Malcolm <dmalcolm@redhat.com> a écrit :
>
>> On Thu, 2022-12-15 at 08:34 +0100, Guillaume Gomez via Jit wrote:
>> > Forgot it indeed, thanks for notifying me!
>> >
>> > I modified the commit message to add it and added it into this email.
>>
>> Sorry about the delay in reviewing this; for some reason I didn't see
>> the mail.
>>
>> The patch looks good for trunk, but please add a reference to
>>   PR jit/107999
>> to the subject line and ChangeLog message.
>>
>> Dave
>>
>> >
>> > Le mer. 14 déc. 2022 à 16:12, Antoni Boucher <bouanto@zoho.com> a
>> > écrit :
>> >
>> > > Thanks!
>> > >
>> > > In your patch, you're missing this line at the end of the commit
>> > > message:
>> > >
>> > >    Signed-off-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
>> > >
>> > > On Wed, 2022-12-14 at 14:39 +0100, Guillaume Gomez via Jit wrote:
>> > > > Hi,
>> > > >
>> > > > This fixes bug 107999.
>> > > >
>> > > > Thanks in advance for the review.
>> > >
>> > >
>>
>>

[-- Attachment #2: 0001-Fix-a-failing-test-by-updating-its-error-string.patch --]
[-- Type: text/x-patch, Size: 1112 bytes --]

From 0835c7ba8bdf4090c7fb102206e70c1ed235808e Mon Sep 17 00:00:00 2001
From: Guillaume Gomez <guillaume1.gomez@gmail.com>
Date: Wed, 14 Dec 2022 14:28:22 +0100
Subject: [PATCH] [PATCH] Fix a failing test by updating its error string
 [PR107999]

gcc/testsuite/ChangeLog:
	PR jit/107999
	* jit.dg/test-error-array-bounds.c: Update test.

Signed-off-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
---
 gcc/testsuite/jit.dg/test-error-array-bounds.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/testsuite/jit.dg/test-error-array-bounds.c b/gcc/testsuite/jit.dg/test-error-array-bounds.c
index b6c0ee526d4..a0dead13cb7 100644
--- a/gcc/testsuite/jit.dg/test-error-array-bounds.c
+++ b/gcc/testsuite/jit.dg/test-error-array-bounds.c
@@ -70,5 +70,5 @@ verify_code (gcc_jit_context *ctxt, gcc_jit_result *result)
   /* ...and that the message was captured by the API.  */
   CHECK_STRING_VALUE (gcc_jit_context_get_first_error (ctxt),
 		      "array subscript 10 is above array bounds of"
-		      " 'char[10]' [-Warray-bounds]");
+		      " 'char[10]' [-Warray-bounds=]");
 }
-- 
2.34.1

Re: [PATCH] libgccjit: Fix a failing test

[David Malcolm]

On Thu, 2023-03-02 at 23:29 +0100, Guillaume Gomez wrote:
> Just realized I used whitespace and not a tab. Sorry about that.
> Here's the
> fixed version...

Looks great.  Do you have push rights, or do you want me to push this?

Thanks
Dave

> 
> Le jeu. 2 mars 2023 à 23:19, Guillaume Gomez
> <guillaume1.gomez@gmail.com> a
> écrit :
> 
> > No problem, thanks for the explanations.
> > 
> > I joined the patch with the fixed commit message.
> > 
> > Le jeu. 2 mars 2023 à 22:58, David Malcolm <dmalcolm@redhat.com> a
> > écrit :
> > 
> > > On Thu, 2022-12-15 at 08:34 +0100, Guillaume Gomez via Jit wrote:
> > > > Forgot it indeed, thanks for notifying me!
> > > > 
> > > > I modified the commit message to add it and added it into this
> > > > email.
> > > 
> > > Sorry about the delay in reviewing this; for some reason I didn't
> > > see
> > > the mail.
> > > 
> > > The patch looks good for trunk, but please add a reference to
> > >   PR jit/107999
> > > to the subject line and ChangeLog message.
> > > 
> > > Dave
> > > 
> > > > 
> > > > Le mer. 14 déc. 2022 à 16:12, Antoni Boucher <bouanto@zoho.com>
> > > > a
> > > > écrit :
> > > > 
> > > > > Thanks!
> > > > > 
> > > > > In your patch, you're missing this line at the end of the
> > > > > commit
> > > > > message:
> > > > > 
> > > > >    Signed-off-by: Guillaume Gomez
> > > > > <guillaume1.gomez@gmail.com>
> > > > > 
> > > > > On Wed, 2022-12-14 at 14:39 +0100, Guillaume Gomez via Jit
> > > > > wrote:
> > > > > > Hi,
> > > > > > 
> > > > > > This fixes bug 107999.
> > > > > > 
> > > > > > Thanks in advance for the review.
> > > > > 
> > > > > 
> > > 
> > > 

Re: [PATCH] libgccjit: Fix a failing test

[Guillaume Gomez]

[-- Attachment #1: Type: text/plain, Size: 1967 bytes --]

I don't have push rights so if you could push it, it'd be super appreciated!

Le jeu. 2 mars 2023 à 23:33, David Malcolm <dmalcolm@redhat.com> a écrit :

> On Thu, 2023-03-02 at 23:29 +0100, Guillaume Gomez wrote:
> > Just realized I used whitespace and not a tab. Sorry about that.
> > Here's the
> > fixed version...
>
> Looks great.  Do you have push rights, or do you want me to push this?
>
> Thanks
> Dave
>
> >
> > Le jeu. 2 mars 2023 à 23:19, Guillaume Gomez
> > <guillaume1.gomez@gmail.com> a
> > écrit :
> >
> > > No problem, thanks for the explanations.
> > >
> > > I joined the patch with the fixed commit message.
> > >
> > > Le jeu. 2 mars 2023 à 22:58, David Malcolm <dmalcolm@redhat.com> a
> > > écrit :
> > >
> > > > On Thu, 2022-12-15 at 08:34 +0100, Guillaume Gomez via Jit wrote:
> > > > > Forgot it indeed, thanks for notifying me!
> > > > >
> > > > > I modified the commit message to add it and added it into this
> > > > > email.
> > > >
> > > > Sorry about the delay in reviewing this; for some reason I didn't
> > > > see
> > > > the mail.
> > > >
> > > > The patch looks good for trunk, but please add a reference to
> > > >   PR jit/107999
> > > > to the subject line and ChangeLog message.
> > > >
> > > > Dave
> > > >
> > > > >
> > > > > Le mer. 14 déc. 2022 à 16:12, Antoni Boucher <bouanto@zoho.com>
> > > > > a
> > > > > écrit :
> > > > >
> > > > > > Thanks!
> > > > > >
> > > > > > In your patch, you're missing this line at the end of the
> > > > > > commit
> > > > > > message:
> > > > > >
> > > > > >    Signed-off-by: Guillaume Gomez
> > > > > > <guillaume1.gomez@gmail.com>
> > > > > >
> > > > > > On Wed, 2022-12-14 at 14:39 +0100, Guillaume Gomez via Jit
> > > > > > wrote:
> > > > > > > Hi,
> > > > > > >
> > > > > > > This fixes bug 107999.
> > > > > > >
> > > > > > > Thanks in advance for the review.
> > > > > >
> > > > > >
> > > >
> > > >
>
>

Re: [PATCH] libgccjit: Fix a failing test

[David Malcolm]

On Thu, 2023-03-02 at 23:35 +0100, Guillaume Gomez wrote:
> I don't have push rights so if you could push it, it'd be super
> appreciated!

Done, as r13-6425-g6b432c0f777ab9; I took the liberty of slightly
tweaking the subject line to add a "jit, testsuite: " prefix.

Thanks again for the patch
Dave

Re: [PATCH] libgccjit: Fix a failing test

[Guillaume Gomez]

[-- Attachment #1: Type: text/plain, Size: 423 bytes --]

Thanks!

Le jeu. 2 mars 2023 à 23:54, David Malcolm <dmalcolm@redhat.com> a écrit :

> On Thu, 2023-03-02 at 23:35 +0100, Guillaume Gomez wrote:
> > I don't have push rights so if you could push it, it'd be super
> > appreciated!
>
> Done, as r13-6425-g6b432c0f777ab9; I took the liberty of slightly
> tweaking the subject line to add a "jit, testsuite: " prefix.
>
> Thanks again for the patch
> Dave
>
>