From: Jan Beulich <jbeulich@suse.com>
To: "Jiang, Haochen" <haochen.jiang@intel.com>
Cc: "hjl.tools@gmail.com" <hjl.tools@gmail.com>,
"Hu, Lin1" <lin1.hu@intel.com>,
"binutils@sourceware.org" <binutils@sourceware.org>
Subject: Re: [PATCH 08/10] Support Intel MSRLIST
Date: Tue, 25 Oct 2022 09:07:23 +0200 [thread overview]
Message-ID: <482ab820-4508-2c28-476b-f1f0a4f7b60c@suse.com> (raw)
In-Reply-To: <SA1PR11MB594683D52649CCC3352C2CB8EC2E9@SA1PR11MB5946.namprd11.prod.outlook.com>
On 24.10.2022 07:56, Jiang, Haochen wrote:
>> -----Original Message-----
>> From: Jan Beulich <jbeulich@suse.com>
>> Sent: Monday, October 17, 2022 3:20 PM
>> To: Jiang, Haochen <haochen.jiang@intel.com>
>> Cc: hjl.tools@gmail.com; Hu, Lin1 <lin1.hu@intel.com>;
>> binutils@sourceware.org
>> Subject: Re: [PATCH 08/10] Support Intel MSRLIST
>>
>> On 14.10.2022 11:12, Haochen Jiang wrote:
>>> From: "Hu, Lin1" <lin1.hu@intel.com>
>>>
>>> gas/ChangeLog:
>>>
>>> * NEWS: Support Intel MSRLIST.
>>> * config/tc-i386.c: Add msrlist.
>>> * doc/c-i386.texi: Document .msrlist and nomsrlist.
>>> * testsuite/gas/i386/i386.exp: Add MSRLIST tests.
>>> * testsuite/gas/i386/x86-64-lockbad-1.l: Add msrlist.
>>> * testsuite/gas/i386/x86-64-lockbad-1.s: Ditto.
>>> * testsuite/gas/i386/msrlist-inval.l: New test.
>>> * testsuite/gas/i386/msrlist-inval.s: Ditto.
>>> * testsuite/gas/i386/x86-64-msrlist-intel.d: Ditto.
>>> * testsuite/gas/i386/x86-64-msrlist.d: Ditto.
>>> * testsuite/gas/i386/x86-64-msrlist.s: Ditto.
>>>
>>> opcodes/ChangeLog:
>>>
>>> * i386-dis.c (X86_64_0F01_REG_0_MOD_3_RM_6_P_1): New.
>>> (X86_64_0F01_REG_0_MOD_3_RM_6_P_3): Ditto.
>>> (prefix_table): New entry for msrlist.
>>> (x86_64_table): Add X86_64_0F01_REG_0_MOD_3_RM_6_P_1
>>> and X86_64_0F01_REG_0_MOD_3_RM_6_P_3.
>>> * i386-gen.c (cpu_flag_init): Add CPU_MSRLIST_FLAGS
>>> and CPU_ANY_MSRLIST_FLAGS.
>>> * i386-init.h: Regenerated.
>>> * i386-opc.h (CpuMSRLIST): New.
>>> (i386_cpu_flags): Add cpumsrlist.
>>> * i386-opc.tbl: Add MSRLIST instructions.
>>> * i386-tbl.h: Regenerated.
>>> ---
>>> gas/NEWS | 2 +
>>> gas/config/tc-i386.c | 1 +
>>> gas/doc/c-i386.texi | 3 +
>>> gas/testsuite/gas/i386/i386.exp | 3 +
>>> gas/testsuite/gas/i386/msrlist-inval.l | 3 +
>>> gas/testsuite/gas/i386/msrlist-inval.s | 7 +
>>> gas/testsuite/gas/i386/x86-64-lockbad-1.l | 100 +-
>>> gas/testsuite/gas/i386/x86-64-lockbad-1.s | 4 +
>>> gas/testsuite/gas/i386/x86-64-msrlist-intel.d | 14 +
>>> gas/testsuite/gas/i386/x86-64-msrlist.d | 14 +
>>> gas/testsuite/gas/i386/x86-64-msrlist.s | 11 +
>>> opcodes/i386-dis.c | 17 +
>>> opcodes/i386-gen.c | 5 +
>>> opcodes/i386-init.h | 516 +-
>>> opcodes/i386-opc.h | 3 +
>>> opcodes/i386-opc.tbl | 7 +
>>> opcodes/i386-tbl.h | 7844 +++++++++--------
>>> 17 files changed, 4350 insertions(+), 4204 deletions(-) create mode
>>> 100644 gas/testsuite/gas/i386/msrlist-inval.l
>>> create mode 100644 gas/testsuite/gas/i386/msrlist-inval.s
>>> create mode 100644 gas/testsuite/gas/i386/x86-64-msrlist-intel.d
>>> create mode 100644 gas/testsuite/gas/i386/x86-64-msrlist.d
>>> create mode 100644 gas/testsuite/gas/i386/x86-64-msrlist.s
>>
>> See some of the comments to patch 7, which apply here equally.
>
> Changes are quite same as patch 7.
>
> In tc-i386.c, we changed ANY_MSRLIST to MSRLIST.
>
> Removed lockbad testcases.
>
> Removed not needed allow_index_reg.
Thanks. Preferably also share dump output expectations here between the
two new testcases.
Jan
next prev parent reply other threads:[~2022-10-25 7:07 UTC|newest]
Thread overview: 120+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 9:12 [PATCH 0/10] Add new Intel Sierra Forest, Grand Ridge, Granite Rapids Instructions Haochen Jiang
2022-10-14 9:12 ` [PATCH 01/10] Support Intel AVX-IFMA Haochen Jiang
2022-10-14 9:52 ` Jan Beulich
2022-10-14 18:10 ` H.J. Lu
2022-10-16 6:39 ` Jan Beulich
2022-10-17 22:23 ` H.J. Lu
2022-10-18 5:33 ` Jan Beulich
2022-10-18 21:28 ` H.J. Lu
2022-10-19 6:01 ` Jan Beulich
2022-10-19 21:27 ` H.J. Lu
2022-10-20 6:15 ` Jan Beulich
2022-10-24 2:07 ` Jiang, Haochen
2022-10-24 5:53 ` Jiang, Haochen
2022-10-24 19:09 ` H.J. Lu
2022-10-25 6:29 ` Jan Beulich
2022-10-14 9:12 ` [PATCH 02/10] Support Intel AVX-VNNI-INT8 Haochen Jiang
2022-10-14 10:57 ` Jan Beulich
2022-10-21 3:22 ` Jiang, Haochen
2022-10-25 1:52 ` H.J. Lu
2022-10-14 9:12 ` [PATCH 03/10] Support Intel AVX-NE-CONVERT Haochen Jiang
2022-10-14 12:58 ` Jan Beulich
2022-10-24 5:37 ` Kong, Lingling
2022-10-24 5:59 ` Kong, Lingling
2022-10-24 19:25 ` H.J. Lu
2022-10-25 6:44 ` Jan Beulich
2022-10-14 9:12 ` [PATCH 04/10] Support Intel CMPccXADD Haochen Jiang
2022-10-14 13:46 ` Jan Beulich
2022-10-14 18:27 ` H.J. Lu
2022-10-14 21:51 ` H.J. Lu
2022-10-16 6:34 ` Jan Beulich
2022-10-17 23:31 ` H.J. Lu
2022-10-16 6:25 ` Jan Beulich
2022-10-17 23:44 ` H.J. Lu
2022-10-16 6:19 ` Jan Beulich
2022-10-24 2:30 ` Jiang, Haochen
2022-10-24 19:12 ` H.J. Lu
2022-10-24 5:55 ` Jiang, Haochen
2022-10-25 6:53 ` Jan Beulich
2022-10-26 3:03 ` Jiang, Haochen
2022-10-26 8:49 ` Jan Beulich
2022-10-27 3:09 ` Jiang, Haochen
2022-10-27 6:37 ` Jan Beulich
2022-10-28 0:59 ` Jiang, Haochen
2022-10-14 9:12 ` [PATCH 05/10] Add handler for more i386_cpu_flags Haochen Jiang
2022-10-14 13:53 ` Jan Beulich
2022-10-14 9:12 ` [PATCH 06/10] Support Intel RAO-INT Haochen Jiang
2022-10-14 14:38 ` Jan Beulich
2022-10-16 6:15 ` Jan Beulich
2022-10-24 3:12 ` Jiang, Haochen
2022-10-24 19:17 ` H.J. Lu
2022-10-24 5:56 ` Jiang, Haochen
2022-10-25 7:01 ` Jan Beulich
2022-10-26 5:16 ` Jiang, Haochen
2022-10-26 8:56 ` Jan Beulich
2022-10-27 3:50 ` Jiang, Haochen
2022-10-27 6:39 ` Jan Beulich
2022-10-27 18:46 ` H.J. Lu
2022-10-28 6:52 ` Jan Beulich
2022-10-28 8:10 ` Jiang, Haochen
2022-10-28 8:22 ` Jan Beulich
2022-10-28 8:31 ` Jiang, Haochen
2022-10-28 8:40 ` Jan Beulich
2022-10-28 16:08 ` H.J. Lu
2022-10-31 9:41 ` Jan Beulich
2022-10-31 16:49 ` H.J. Lu
2022-11-06 12:50 ` Kong, Lingling
2022-11-07 9:24 ` Jan Beulich
2022-11-07 13:37 ` Kong, Lingling
2022-11-07 20:03 ` H.J. Lu
2022-10-17 23:23 ` H.J. Lu
2022-10-18 5:38 ` Jan Beulich
2022-10-14 9:12 ` [PATCH 07/10] Support Intel WRMSRNS Haochen Jiang
2022-10-17 7:17 ` Jan Beulich
2022-10-24 2:52 ` Jiang, Haochen
2022-10-24 5:56 ` Jiang, Haochen
2022-10-24 19:14 ` H.J. Lu
2022-10-25 7:04 ` Jan Beulich
2022-10-14 9:12 ` [PATCH 08/10] Support Intel MSRLIST Haochen Jiang
2022-10-17 7:20 ` Jan Beulich
2022-10-24 3:03 ` Jiang, Haochen
2022-10-24 5:56 ` Jiang, Haochen
2022-10-24 19:15 ` H.J. Lu
2022-10-25 7:07 ` Jan Beulich [this message]
2022-10-14 9:12 ` [PATCH 09/10] Support Intel AMX-FP16 Haochen Jiang
2022-10-17 7:35 ` Jan Beulich
2022-10-18 9:01 ` Cui, Lili
2022-10-18 9:23 ` Jan Beulich
2022-10-18 9:33 ` Jiang, Haochen
2022-10-19 10:33 ` Cui, Lili
2022-10-19 13:35 ` Jan Beulich
2022-10-19 14:05 ` Cui, Lili
2022-10-19 14:09 ` Jan Beulich
2022-10-19 14:41 ` Cui, Lili
2022-10-19 15:04 ` Jan Beulich
2022-10-19 15:21 ` Cui, Lili
2022-10-19 14:01 ` Jiang, Haochen
2022-10-19 14:13 ` Jan Beulich
2022-10-19 14:58 ` Jiang, Haochen
2022-10-25 6:02 ` Jan Beulich
2022-10-25 13:05 ` Cui, Lili
2022-10-14 9:12 ` [PATCH 10/10] Support Intel PREFETCHI Haochen Jiang
2022-10-17 8:15 ` Jan Beulich
2022-10-25 13:03 ` Cui, Lili
2022-10-25 15:41 ` Jan Beulich
2022-10-25 15:52 ` Jan Beulich
2022-10-25 17:01 ` H.J. Lu
2022-10-26 13:42 ` Cui, Lili
2022-10-26 13:53 ` Jan Beulich
2022-10-27 6:04 ` Cui, Lili
2022-10-27 6:45 ` Jan Beulich
2022-10-27 7:01 ` Cui, Lili
2022-10-27 7:15 ` Jan Beulich
2022-10-27 7:43 ` Cui, Lili
2022-10-28 9:03 ` Cui, Lili
2022-10-28 15:54 ` H.J. Lu
2022-10-31 13:23 ` Cui, Lili
2022-10-31 14:45 ` Mike Frysinger
2022-10-31 16:25 ` H.J. Lu
2022-10-19 14:55 [PATCH v2 0/10] Add new Intel Sierra Forest, Grand Ridge, Granite Rapids Instructions Haochen Jiang
2022-10-19 14:56 ` [PATCH 08/10] Support Intel MSRLIST Haochen Jiang
2022-10-19 15:15 [PATCH v2 0/10] Add new Intel Sierra Forest, Grand Ridge, Granite Rapids Instructions (Resend) Haochen Jiang
2022-10-19 15:15 ` [PATCH 08/10] Support Intel MSRLIST Haochen Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=482ab820-4508-2c28-476b-f1f0a4f7b60c@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=haochen.jiang@intel.com \
--cc=hjl.tools@gmail.com \
--cc=lin1.hu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).