Re: [PATCH 02/10] Support Intel AVX-VNNI-INT8

["H.J. Lu" <hjl.tools@gmail.com>]

On Thu, Oct 20, 2022 at 8:22 PM Jiang, Haochen <haochen.jiang@intel.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Jan Beulich <jbeulich@suse.com>
> > Sent: Friday, October 14, 2022 6:58 PM
> > To: Jiang, Haochen <haochen.jiang@intel.com>
> > Cc: hjl.tools@gmail.com; Cui, Lili <lili.cui@intel.com>;
> > binutils@sourceware.org
> > Subject: Re: [PATCH 02/10] Support Intel AVX-VNNI-INT8
> >
> > On 14.10.2022 11:12, Haochen Jiang wrote:
> > > --- a/opcodes/i386-gen.c
> > > +++ b/opcodes/i386-gen.c
> > > @@ -247,6 +247,8 @@ static initializer cpu_flag_init[] =
> > >      "CPU_AVX512BW_FLAGS|CpuAVX512_FP16" },
> > >    { "CPU_AVX_IFMA_FLAGS",
> > >      "CPU_AVX2_FLAGS|CpuAVX_IFMA" },
> > > +  { "CPU_AVX_VNNI_INT8_FLAGS",
> > > +    "CPU_AVX2_FLAGS|CpuAVX_VNNI_INT8" },
> > >    { "CPU_IAMCU_FLAGS",
> > >      "Cpu186|Cpu286|Cpu386|Cpu486|Cpu586|CpuIAMCU" },
> > >    { "CPU_ADX_FLAGS",
> > > @@ -443,6 +445,8 @@ static initializer cpu_flag_init[] =
> > >      "CpuAVX512_FP16" },
> > >    { "CPU_ANY_AVX_IFMA_FLAGS",
> > >      "CpuAVX_IFMA" },
> > > +  { "CPU_ANY_AVX_VNNI_INT8_FLAGS",
> > > +    "CpuAVX_VNNI_INT8" },
> > >  };
> >
> > Like in patch 1 CPU_ANY_AVX2_FLAGS also needs adjustment if AVX2 is
> > taken as a prereq to AVX-VNNI-INT8.
>
> Fixed.
>
> Also changed the AVX_VNNI_INT8 in comments in i386-opc.tbl to AVX-VNNI-INT8.
>
> Haochen
> >
> > Jan

OK.

Thanks.

-- 
H.J.