public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Michael Meissner <meissner@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc(refs/users/meissner/heads/work119)] Revert patches
Date: Fri, 21 Apr 2023 19:36:36 +0000 (GMT)	[thread overview]
Message-ID: <20230421193636.4D48F3858D20@sourceware.org> (raw)

https://gcc.gnu.org/g:f5002e5626c8c6502fc6a377965a9424aa6160bc

commit f5002e5626c8c6502fc6a377965a9424aa6160bc
Author: Michael Meissner <meissner@linux.ibm.com>
Date:   Fri Apr 21 15:36:32 2023 -0400

    Revert patches

Diff:
---
 gcc/config/rs6000/vsx.md                           | 55 +++-------------------
 .../gcc.target/powerpc/vec-extract-mem-float-1.c   | 29 ------------
 .../gcc.target/powerpc/vec-extract-mem-float-2.c   | 27 -----------
 3 files changed, 6 insertions(+), 105 deletions(-)

diff --git a/gcc/config/rs6000/vsx.md b/gcc/config/rs6000/vsx.md
index ea29df72ccc..417aff5e24b 100644
--- a/gcc/config/rs6000/vsx.md
+++ b/gcc/config/rs6000/vsx.md
@@ -3549,7 +3549,6 @@
   [(set_attr "length" "8")
    (set_attr "type" "fp")])
 
-;; V4SF extract from memory convert to DFmode with constant element number.
 (define_insn_and_split "*vsx_extract_v4sf_load"
   [(set (match_operand:SF 0 "register_operand" "=f,v,v,?r")
 	(vec_select:SF
@@ -3558,7 +3557,7 @@
    (clobber (match_scratch:P 3 "=&b,&b,&b,&b"))]
   "VECTOR_MEM_VSX_P (V4SFmode)"
   "#"
-  "&& 1"
+  "&& reload_completed"
   [(set (match_dup 0) (match_dup 4))]
 {
   operands[4] = rs6000_adjust_vec_address (operands[0], operands[1], operands[2],
@@ -3568,27 +3567,6 @@
    (set_attr "length" "8")
    (set_attr "isa" "*,p7v,p9v,*")])
 
-;; V4SF extract from memory and convert to DFmode with constant element number.
-(define_insn_and_split "*vsx_extract_v4sf_load_to_df"
-  [(set (match_operand:DF 0 "register_operand" "=f,v,v")
-	(float_extend:DF
-	 (vec_select:SF
-	  (match_operand:V4SF 1 "memory_operand" "m,Z,m")
-	  (parallel [(match_operand:QI 2 "const_0_to_3_operand" "n,n,n")]))))
-   (clobber (match_scratch:P 3 "=&b,&b,&b"))]
-  "VECTOR_MEM_VSX_P (V4SFmode)"
-  "#"
-  "&& 1"
-  [(set (match_dup 0)
-	(float_extend:DF (match_dup 4)))]
-{
-  operands[4] = rs6000_adjust_vec_address (operands[0], operands[1], operands[2],
-					   operands[3], SFmode);
-}
-  [(set_attr "type" "fpload")
-   (set_attr "length" "8")
-   (set_attr "isa" "*,p7v,p9v")])
-
 ;; Variable V4SF extract from a register
 (define_insn_and_split "vsx_extract_v4sf_var"
   [(set (match_operand:SF 0 "gpc_reg_operand" "=wa")
@@ -3607,43 +3585,22 @@
   DONE;
 })
 
-;; V4SF extract from memory with variable element number.
+;; Variable V4SF extract from memory
 (define_insn_and_split "*vsx_extract_v4sf_var_load"
   [(set (match_operand:SF 0 "gpc_reg_operand" "=wa,?r")
 	(unspec:SF [(match_operand:V4SF 1 "memory_operand" "Q,Q")
 		    (match_operand:DI 2 "gpc_reg_operand" "r,r")]
 		   UNSPEC_VSX_EXTRACT))
-   (clobber (match_scratch:P 3 "=&b,&b"))]
-  "VECTOR_MEM_VSX_P (V4SFmode)"
+   (clobber (match_scratch:DI 3 "=&b,&b"))]
+  "VECTOR_MEM_VSX_P (V4SFmode) && TARGET_DIRECT_MOVE_64BIT"
   "#"
-  "&& 1"
+  "&& reload_completed"
   [(set (match_dup 0) (match_dup 4))]
 {
   operands[4] = rs6000_adjust_vec_address (operands[0], operands[1], operands[2],
 					   operands[3], SFmode);
 }
-  [(set_attr "type" "fpload,load")
-   (set_attr "length" "12")])
-
-;; V4SF extract from memory and convert to DFmode with variable element number.
-(define_insn_and_split "*vsx_extract_v4sf_var_load_to_df"
-  [(set (match_operand:DF 0 "gpc_reg_operand" "=wa")
-	(float_extend:DF
-	 (unspec:SF [(match_operand:V4SF 1 "memory_operand" "Q")
-		     (match_operand:DI 2 "gpc_reg_operand" "r")]
-		    UNSPEC_VSX_EXTRACT)))
-   (clobber (match_scratch:P 3 "=&b"))]
-  "VECTOR_MEM_VSX_P (V4SFmode)"
-  "#"
-  "&& 1"
-  [(set (match_dup 0)
-	(float_extend:DF (match_dup 4)))]
-{
-  operands[4] = rs6000_adjust_vec_address (operands[0], operands[1], operands[2],
-					   operands[3], SFmode);
-}
-  [(set_attr "type" "fpload")
-   (set_attr "length" "12")])
+  [(set_attr "type" "fpload,load")])
 
 ;; Expand the builtin form of xxpermdi to canonical rtl.
 (define_expand "vsx_xxpermdi_<mode>"
diff --git a/gcc/testsuite/gcc.target/powerpc/vec-extract-mem-float-1.c b/gcc/testsuite/gcc.target/powerpc/vec-extract-mem-float-1.c
deleted file mode 100644
index eab7892ed80..00000000000
--- a/gcc/testsuite/gcc.target/powerpc/vec-extract-mem-float-1.c
+++ /dev/null
@@ -1,29 +0,0 @@
-/* { dg-do compile } */
-/* { dg-require-effective-target powerpc_vsx_ok } */
-/* { dg-options "-O2 -mvsx" } */
-
-/* Test to verify that the vec_extract with constant element numbers can load
-   float (SF) variables into a GPR without doing a LFS or STFS.  */
-
-#include <altivec.h>
-
-float
-extract_float_0_gpr (vector float *p, float *q)
-{
-  float x = vec_extract (*p, 0);
-  __asm__ ("# %0" : "+r" (x));			/* lwz.  */
-  *q = x;
-}
-
-float
-extract_float_3_gpr (vector float *p, float *q)
-{
-  float x = vec_extract (*p, 3);
-  __asm__ ("# %0" : "+r" (x));			/* lwz.  */
-  *q = x;
-}
-
-/* { dg-final { scan-assembler-times {\mlwz\M}               2 } } */
-/* { dg-final { scan-assembler-times {\mstwz\M}              2 } } */
-/* { dg-final { scan-assembler-not   {\mlfs\M|\mlxsspx?\M}     } } */
-/* { dg-final { scan-assembler-not   {\mstfs\M|\mstxsspx?\M}   } } */
diff --git a/gcc/testsuite/gcc.target/powerpc/vec-extract-mem-float-2.c b/gcc/testsuite/gcc.target/powerpc/vec-extract-mem-float-2.c
deleted file mode 100644
index af66fd20c21..00000000000
--- a/gcc/testsuite/gcc.target/powerpc/vec-extract-mem-float-2.c
+++ /dev/null
@@ -1,27 +0,0 @@
-/* { dg-do compile } */
-/* { dg-require-effective-target powerpc_vsx_ok } */
-/* { dg-options "-O2 -mvsx" } */
-
-/* Test to verify that the vec_extract with variable element numbers can load
-   float (SF) variables directly using a single LFSX or LXSSPX instruction.  */
-
-#include <altivec.h>
-#include <stddef.h>
-
-float
-extract_float_var (vector float *p, size_t n)
-{
-  return vec_extract (*p, n);		/* lfsx or lxsspx.  */
-}
-
-double
-extract_float_to_double_var (vector float *p, size_t n)
-{
-  return vec_extract (*p, n);		/* lfsx or lxsspx.  */
-}
-
-/* { dg-final { scan-assembler-times {\mlfsx\M|\{mlxsspx\M}  2 } } */
-/* { dg-final { scan-assembler-not   {\mlxv\M|\mlxvx\M}        } } */
-/* { dg-final { scan-assembler-not   {\mm[tf]vsr}              } } */
-/* { dg-final { scan-assembler-not   {\mvslo\M}                } } */
-/* { dg-final { scan-assembler-not   {\mxscvspdp\M}            } } */

             reply	other threads:[~2023-04-21 19:36 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-21 19:36 Michael Meissner [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-05-01 17:16 Michael Meissner
2023-04-29  1:28 Michael Meissner
2023-04-28 22:57 Michael Meissner
2023-04-28 21:39 Michael Meissner
2023-04-28 21:30 Michael Meissner
2023-04-28 19:07 Michael Meissner
2023-04-28 18:28 Michael Meissner
2023-04-28 18:11 Michael Meissner
2023-04-28 17:33 Michael Meissner
2023-04-28  6:29 Michael Meissner
2023-04-28  3:57 Michael Meissner
2023-04-27 20:50 Michael Meissner
2023-04-27 19:33 Michael Meissner
2023-04-27 19:11 Michael Meissner
2023-04-27  2:58 Michael Meissner
2023-04-27  2:51 Michael Meissner
2023-04-27  2:48 Michael Meissner
2023-04-26 23:55 Michael Meissner
2023-04-26 15:37 Michael Meissner
2023-04-26 15:35 Michael Meissner
2023-04-26  5:05 Michael Meissner
2023-04-25 22:46 Michael Meissner
2023-04-25 15:48 Michael Meissner
2023-04-25  6:40 Michael Meissner
2023-04-25  6:28 Michael Meissner
2023-04-25  2:15 Michael Meissner
2023-04-25  1:58 Michael Meissner
2023-04-25  1:51 Michael Meissner
2023-04-24 22:57 Michael Meissner
2023-04-22  5:50 Michael Meissner
2023-04-21 23:07 Michael Meissner
2023-04-21 23:05 Michael Meissner
2023-04-21 20:19 Michael Meissner
2023-04-21 19:50 Michael Meissner
2023-04-21 19:03 Michael Meissner
2023-04-21 18:10 Michael Meissner
2023-04-21 15:37 Michael Meissner
2023-04-21 15:36 Michael Meissner
2023-04-21 15:27 Michael Meissner
2023-04-21 15:09 Michael Meissner
2023-04-21  3:57 Michael Meissner
2023-04-21  3:45 Michael Meissner
2023-04-21  3:09 Michael Meissner
2023-04-20 23:41 Michael Meissner
2023-04-19 22:11 Michael Meissner
2023-04-19 21:47 Michael Meissner
2023-04-19 19:28 Michael Meissner
2023-04-19 19:21 Michael Meissner
2023-04-19 19:14 Michael Meissner
2023-04-19 16:36 Michael Meissner
2023-04-19 16:22 Michael Meissner
2023-04-18 22:13 Michael Meissner
2023-04-18  5:37 Michael Meissner
2023-04-17 22:28 Michael Meissner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230421193636.4D48F3858D20@sourceware.org \
    --to=meissner@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).